-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license: add ASF header. #743
Conversation
effcea0
to
d916a19
Compare
do we need to add a ignore file list? |
sure, here is the exclude file list: https://github.com/iresty/apisix/pull/743/files#diff-fddd45f9d2486fc66aae183c85faeadcR81 |
@moonming https://travis-ci.org/iresty/apisix/builds/603466982#L696 please rebase your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked all files which were added ASF header, no issues were found.
@moonming travis still fail
|
So this file is using an incorrect ASF header? |
@juzhiyuan can you change to this style: https://github.com/apache/incubator-apisix/pull/743/files#diff-1fe3647ec3125ba1bcdbd7c830ada01d? |
1a5327f
to
74e4137
Compare
@moonming please rebase your branch. |
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
Full changelog
Issues resolved
Fix #XXX