Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: add ASF header. #743

Merged
merged 5 commits into from
Oct 31, 2019
Merged

license: add ASF header. #743

merged 5 commits into from
Oct 31, 2019

Conversation

moonming
Copy link
Member

@moonming moonming commented Oct 26, 2019

NOTE: Please read the Contributing.md guidelines before submitting your patch:

https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one

Summary

Full changelog

  • [Implement ...]
  • [Add related tests]
  • ...

Issues resolved

Fix #XXX

@moonming moonming force-pushed the asf-header branch 2 times, most recently from effcea0 to d916a19 Compare October 26, 2019 11:54
@membphis
Copy link
Member

do we need to add a ignore file list?

@membphis
Copy link
Member

image

@moonming moonming changed the title add asf header for files. license: add ASF header. Oct 26, 2019
@moonming
Copy link
Member Author

moonming commented Oct 26, 2019

do we need to add a ignore file list?

sure, here is the exclude file list: https://github.com/iresty/apisix/pull/743/files#diff-fddd45f9d2486fc66aae183c85faeadcR81

@membphis
Copy link
Member

@moonming https://travis-ci.org/iresty/apisix/builds/603466982#L696

please rebase your branch.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked all files which were added ASF header, no issues were found.

@membphis
Copy link
Member

@moonming travis still fail

.travis/openwhisk-utilities/scancode/scanCode.py --config .travis/ASF-Release.cfg ./
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 1 error(s) in 1 file(s):
  [./dashboard/index.html]:
       1: file does not include required license header.

@juzhiyuan
Copy link
Member

index.html

So this file is using an incorrect ASF header?
https://github.com/iresty/apisix_dashboard_built/blob/fde8c24f536659e33e899d4adc3d6b48d658a6a2/index.html

@moonming
Copy link
Member Author

moonming commented Oct 30, 2019

index.html

So this file is using an incorrect ASF header?
https://github.com/iresty/apisix_dashboard_built/blob/fde8c24f536659e33e899d4adc3d6b48d658a6a2/index.html

@juzhiyuan can you change to this style: https://github.com/apache/incubator-apisix/pull/743/files#diff-1fe3647ec3125ba1bcdbd7c830ada01d?
.travis/ASFLicenseHeaderMarkdown.txt

@moonming moonming force-pushed the asf-header branch 2 times, most recently from 1a5327f to 74e4137 Compare October 30, 2019 09:56
@membphis
Copy link
Member

@moonming please rebase your branch.

@moonming moonming merged commit 12a2b01 into apache:master Oct 31, 2019
@moonming moonming deleted the asf-header branch October 31, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants