Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use original modifiedIndex if possible #4192

Merged
merged 2 commits into from
May 9, 2021
Merged

Conversation

spacewander
Copy link
Member

Fix #4160

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Fix apache#4160

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review May 7, 2021 02:38
@Yiyiyimu
Copy link
Member

Yiyiyimu commented May 7, 2021

I test dozens of times with the reproduce steps from @tzssangglass and also this new test on master branch, and both of them passed without errors. Is there any specific reason to cause this problem, since it seems not always happen.

And if it is triggered randomly, do we need to test it several times to ensure the error would not occur

@spacewander
Copy link
Member Author

@Yiyiyimu
It can be simply reproduced with running my test without my fix.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@Yiyiyimu
Copy link
Member

Yiyiyimu commented May 8, 2021

@Yiyiyimu
It can be simply reproduced with running my test without my fix.

Could reproduce for now. Can't find the reason yet maybe there is something configured wrong on my local environment..

@tokers tokers merged commit 19dbe34 into apache:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Seek help !Problems of Prometheus, This should be a bug, please fix it!!!
4 participants