Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: independently check the "disabled" field to avoid schema ve… #2099

Merged
merged 7 commits into from
Sep 17, 2020
Merged

bugfix: independently check the "disabled" field to avoid schema ve… #2099

merged 7 commits into from
Sep 17, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Aug 22, 2020

…rification

with other parameters.

What this PR does / why we need it:

fix #2084

=== TEST 4: get plugin node-status schema
--- request
GET /apisix/admin/plugins/node-status
--- response_body
{"properties":{"disable":{"type":"boolean"}},"additionalProperties":false,"type":"object"}
--- no_error_log
[error]



=== TEST 5: get plugin prometheus schema
--- request
GET /apisix/admin/plugins/prometheus
--- response_body
{"properties":{"disable":{"type":"boolean"}},"additionalProperties":false,"type":"object"}
--- no_error_log
[error]

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@moonming moonming added this to the 2.0 milestone Sep 16, 2020
@membphis
Copy link
Member Author

@nic-chen do you have time to review this PR ?

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: Update plugin's schema prometheus & node-status
3 participants