-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add 3 plugin test cases for e2e #965
Conversation
Please run |
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 31.75% 31.91% +0.15%
==========================================
Files 72 73 +1
Lines 7935 7953 +18
==========================================
+ Hits 2520 2538 +18
Misses 5139 5139
Partials 276 276
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Only one point needs to be adjusted, other contents LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @AlinsRan , thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt |
Type of change:
What this PR does / why we need it:
Test cases include:
Pre-submission checklist: