Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ApisixConsumerBasicAuthValue password-yaml field error #960

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Apr 12, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #960 (2b516e5) into master (22cfb5e) will not change coverage.
The diff coverage is n/a.

❗ Current head 2b516e5 differs from pull request most recent head 23d09ea. Consider uploading reports for the commit 23d09ea to get more accurate results

@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          72       72           
  Lines        7935     7935           
=======================================
  Hits         2520     2520           
  Misses       5139     5139           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cfb5e...23d09ea. Read the comment docs.

@gxthrj gxthrj merged commit aee6e78 into apache:master Apr 13, 2022
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants