feat: Fix lb ingress status #740
Conversation
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 32.28% 32.08% -0.21%
==========================================
Files 66 66
Lines 6808 6944 +136
==========================================
+ Hits 2198 2228 +30
- Misses 4353 4466 +113
+ Partials 257 250 -7
Continue to review full report at Codecov.
|
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
…troller into fix-lb-ingress-status
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
| return addrs, nil | ||
| } | ||
|
|
||
| namespace, name, err := cache.SplitMetaNamespaceKey(ingressPublishService) |
There was a problem hiding this comment.
The separation can be handled in advance.
There was a problem hiding this comment.
I didn't understand what you mean.
There was a problem hiding this comment.
This specified service is only needed here, I don’t think it needs to be checked or processed in advance.
There was a problem hiding this comment.
Since the namespace is passed from users, we can split it and check the validity when the program is starting, so we can avoid such an error check here and we can abort the program in time (if the format is incorrect).
There was a problem hiding this comment.
But users may not configure Ingress resources.
If the user configures this option, but he only uses custom resources, do we also need to report an error? And if there is any error, it will not affect the actual use of the user.
There was a problem hiding this comment.
Because it is not a parameter required by the real runtime, I don’t want to refuse to provide services to users in advance.
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
|
I will fix CI ASAP |
…troller into fix-lb-ingress-status
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
bug: Ingress Status Load Balancer IPs Not Being Updated #690
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch