-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore delete pod cache error msg #714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
============================================
+ Coverage 32.36% 100.00% +67.63%
============================================
Files 65 1 -64
Lines 6488 1 -6487
============================================
- Hits 2100 1 -2099
+ Misses 4137 0 -4137
+ Partials 251 0 -251 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please fix the unit test case.
--- FAIL: TestPodCacheBadCases (0.00s)
pod_test.go:39:
Error Trace: pod_test.go:39
Error: Not equal:
expected: <nil>(<nil>)
actual : *errors.errorString(&errors.errorString{s:"pod not running"})
Test: TestPodCacheBadCases
Messages: deleting pod
FAIL
coverage: 87.0% of statements
FAIL github.com/apache/apisix-ingress-controller/pkg/types 0.005s
? github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1 [no test files]
ok github.com/apache/apisix-ingress-controller/pkg/version 0.003s coverage: 100.0% of statements
FAIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
request help: error log "failed to delete pod from cache" #684
Bugfix
Description
How to fix?
modify the return value
ErrPodNoAssignedIP
->nil
.