-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade ApisixRoute v2beta2 apiversion. #698
Conversation
**Notice:** * remove `spec.backend` * remove `spec.tcp` Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
need to be done:
|
I think we should try to generate crd from their data structure definition in the future, to avoid writing them by hands. |
Yes, we have created an issue for tracking. #515 We can deal with it in the next version. By the way, I suggest to unify the existing CRD apiversion in this project, which can reduce the learning cost of users and facilitate unified management. |
@tao12345666333 there are still some lint errors. |
yep. just edit on GitHub codespace. I will fix it ASAP |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 34.04% 32.86% -1.19%
==========================================
Files 61 62 +1
Lines 6144 6369 +225
==========================================
+ Hits 2092 2093 +1
- Misses 3801 4025 +224
Partials 251 251
Continue to review full report at Codecov.
|
Please check lint error. |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just fix linter errors
when using |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
…troller into feat-ar-v2beta2
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@gxthrj @tokers @lingsamuel PTAL |
Notice:
spec.backend
spec.tcp
Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Closes #692
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch