feat: support cert-manager #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 413 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 220 | 2 | 191 | 0 |
Click to see the invalid file list
- docs/en/latest/practices/cert-manager/ca.yaml
- docs/en/latest/practices/cert-manager/issuer.yaml
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 35.04% 34.88% -0.16%
==========================================
Files 60 60
Lines 5967 5994 +27
==========================================
Hits 2091 2091
- Misses 3625 3652 +27
Partials 251 251
Continue to review full report at Codecov.
|
gxthrj
reviewed
Sep 17, 2021
docs/en/latest/practices/manage-certificates-with-cert-manager.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
gxthrj
approved these changes
Sep 24, 2021
docs/en/latest/practices/manage-certificates-with-cert-manager.md
Outdated
Show resolved
Hide resolved
docs/en/latest/practices/manage-certificates-with-cert-manager.md
Outdated
Show resolved
Hide resolved
docs/en/latest/practices/manage-certificates-with-cert-manager.md
Outdated
Show resolved
Hide resolved
docs/en/latest/practices/manage-ingress-certificates-with-cert-manager.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
tao12345666333
added
changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Fixes feat: Integrate cert-manager to manage secrets #548
New feature or improvement
APISIX ingress controller now only supports secerts with
certandkeyfields, which is not Kubernetes style. Secrets created by cert-manager contain the standrd k8s-style fieldsca.crt,tls.crtandtls.key.This PR makes APISIX ingress controller to support both old field names and k8s standard field names, which allows APISIX ingress controller to work with cert-manager.