Remove volumeMounts when webhook is disabled #679
Conversation
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
Continue to review full report at Codecov.
|
| @@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema, | |||
| ) | |||
| } | |||
|
|
|||
| url := sc.url + "/" + name | |||
| url := sc.url + name | |||
There was a problem hiding this comment.
Why change this? Maybe path.Join is more appropriate.
There was a problem hiding this comment.
Because I checked logs of E2E test and found there is a duplicated /:
There was a problem hiding this comment.
OK, use path.Join is better.
There was a problem hiding this comment.
It's not suitable to use path.Join:
| @@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema, | |||
| ) | |||
| } | |||
|
|
|||
| url := sc.url + "/" + name | |||
| url := sc.url + name | |||
There was a problem hiding this comment.
OK, use path.Join is better.
* Remove volumeMounts when webhook is disabled
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
It will occur errors when webhook is disabled but the controller pod tried to mount the volume.
How to fix?
Add a placeholder in deployment template, decide whether to populate the
volumeMountor not according to whether the webhook is enabled.