Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TLS for ingress v1 #634

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

lingsamuel
Copy link
Member

@lingsamuel lingsamuel commented Aug 17, 2021

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com


New feature or improvement

  • Support ingress v1 TLS field

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #634 (144ecb0) into master (91d985e) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 144ecb0 differs from pull request most recent head 4fe3329. Consider uploading reports for the commit 4fe3329 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   34.46%   34.31%   -0.15%     
==========================================
  Files          57       57              
  Lines        5722     5746      +24     
==========================================
  Hits         1972     1972              
- Misses       3504     3527      +23     
- Partials      246      247       +1     
Impacted Files Coverage Δ
pkg/ingress/manifest.go 53.74% <ø> (ø)
pkg/kube/translation/ingress.go 68.83% <0.00%> (-8.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8854c3...4fe3329. Read the comment docs.

@tao12345666333 tao12345666333 added this to the 1.3.0 milestone Aug 17, 2021
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release feature labels Aug 18, 2021
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel requested a review from tokers August 18, 2021 09:16
@lingsamuel
Copy link
Member Author

Review fixed, cc @tokers @tao12345666333

@tao12345666333
Copy link
Member

skip flaky tests

@tao12345666333 tao12345666333 merged commit 62b7590 into apache:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Issues with this label should be added to changelog when public a new release feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add TLS support for Ingress resources
4 participants