-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metric 'check_cluster_health_total' and 'sync_operation_total' #627
Conversation
for the metric: apisix_ingress_controller_sync_success, how to describe the following: |
assert.Equal(t, *m[0].Gauge.Value, float64(1)) | ||
assert.Equal(t, *m[0].Label[0].Name, "controller_namespace") | ||
assert.Equal(t, *m[0].Label[0].Value, "default") | ||
assert.Equal(t, *m[0].Label[1].Name, "controller_pod") | ||
assert.Equal(t, *m[0].Label[1].Value, "test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we put podName
and podNamespace
inside NewPrometheusCollector()
, transfer param "test"
to collector is disabled.
so the test result of controller_pod
should be ""
.
|
54e4de8
to
7ba9956
Compare
done. |
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 34.79% 34.74% -0.05%
==========================================
Files 57 57
Lines 5722 5773 +51
==========================================
+ Hits 1991 2006 +15
- Misses 3492 3521 +29
- Partials 239 246 +7
Continue to review full report at Codecov.
|
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
New feature or improvement
add two Promethues metrics for apisix-ingress-controller:
HELP apisix_ingress_controller_check_cluster_health_success Number of cluster health check operations
TYPE apisix_ingress_controller_check_cluster_health_success counter
Label:
HELP apisix_ingress_controller_sync_success Number of success sync operations
TYPE apisix_ingress_controller_sync_success counter
Labels:
Show in Prometheus: