Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement schema API #601

Merged
merged 13 commits into from
Aug 5, 2021
Merged

feat: implement schema API #601

merged 13 commits into from
Aug 5, 2021

Conversation

fgksgf
Copy link
Member

@fgksgf fgksgf commented Jul 19, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


New feature or improvement

  • Implement schema API for getting plugin's schema from APISIX.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #601 (9cbad13) into master (5635652) will increase coverage by 0.40%.
The diff coverage is 44.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   34.05%   34.46%   +0.40%     
==========================================
  Files          55       57       +2     
  Lines        5544     5722     +178     
==========================================
+ Hits         1888     1972      +84     
- Misses       3430     3504      +74     
- Partials      226      246      +20     
Impacted Files Coverage Δ
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.07% <0.00%> (ø)
pkg/apisix/nonexistentclient.go 44.44% <28.57%> (-1.99%) ⬇️
pkg/apisix/cluster.go 27.20% <31.00%> (+1.87%) ⬆️
pkg/apisix/apisix.go 67.50% <50.00%> (ø)
pkg/apisix/schema.go 58.13% <58.13%> (ø)
pkg/apisix/cache/memdb.go 75.00% <76.47%> (+0.15%) ⬆️
pkg/apisix/plugin.go 80.00% <80.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5635652...9cbad13. Read the comment docs.

pkg/types/apisix/v1/types.go Show resolved Hide resolved
pkg/apisix/cluster.go Show resolved Hide resolved
pkg/apisix/cache/cache.go Show resolved Hide resolved
pkg/apisix/apisix.go Show resolved Hide resolved
@fgksgf fgksgf changed the title feat: implement plugin schema API feat: implement schema API Jul 21, 2021
pkg/apisix/plugin.go Show resolved Hide resolved
pkg/apisix/plugin_test.go Outdated Show resolved Hide resolved
pkg/apisix/schema.go Show resolved Hide resolved
pkg/apisix/plugin.go Outdated Show resolved Hide resolved
pkg/apisix/cluster_test.go Outdated Show resolved Hide resolved
pkg/apisix/cluster.go Outdated Show resolved Hide resolved
@fgksgf
Copy link
Member Author

fgksgf commented Jul 23, 2021

It's weird, all unit tests passed on my PC but failed in CI.

pkg/apisix/cluster.go Outdated Show resolved Hide resolved
@tokers
Copy link
Contributor

tokers commented Jul 26, 2021

@fgksgf Please check out the CI failure problems, especially for the unit test cases.

@gxthrj
Copy link
Contributor

gxthrj commented Jul 30, 2021

It's weird, all unit tests passed on my PC but failed in CI.

UT passed.

pkg/apisix/cluster.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

This PR need rebase.

pkg/apisix/cluster.go Outdated Show resolved Hide resolved
@gxthrj gxthrj merged commit e5441a3 into apache:master Aug 5, 2021
@fgksgf fgksgf deleted the schema-plugin-api branch August 5, 2021 12:41
fgksgf added a commit to fgksgf/apisix-ingress-controller that referenced this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants