feat: consumer controller loop #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsumer-translator
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
|
let me rebase and resolve conflicts. |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tokers
reviewed
Jun 1, 2021
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tokers
approved these changes
Jun 2, 2021
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
…troller into feat-consumer-controller-loop-merge
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 36.21% 35.00% -1.22%
==========================================
Files 53 54 +1
Lines 4343 4497 +154
==========================================
+ Hits 1573 1574 +1
- Misses 2558 2711 +153
Partials 212 212
Continue to review full report at Codecov.
|
tokers
approved these changes
Jun 2, 2021
tao12345666333
commented
Jun 2, 2021
| @@ -164,7 +167,8 @@ func NewController(cfg *config.Config) (*Controller, error) { | |||
| watchingNamespace: watchingNamespace, | |||
| secretSSLMap: new(sync.Map), | |||
| recorder: eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: _component}), | |||
| podCache: types.NewPodCache(), | |||
|
|
|||
gxthrj
approved these changes
Jun 2, 2021
This was referenced Jun 4, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch