feat: ingress v1 #250
Merged
feat: ingress v1 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
Continue to review full report at Codecov.
|
gxthrj
reviewed
Feb 17, 2021
cmd/ingress/ingress_test.go
Outdated
| @@ -105,6 +105,9 @@ func TestSignalHandler(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestNewIngressCommandEffectiveLog(t *testing.T) { | |||
| // Delay for 2 seconds to avoid conflicting with the | |||
| // TestSignalHandler case. | |||
| time.Sleep(2 * time.Second) | |||
There was a problem hiding this comment.
It is strange, if the port conflict, we need to retry.
There was a problem hiding this comment.
Not the conflicts of port, just like the conflicts about terminal (stdout).
There was a problem hiding this comment.
Fixed by another way.
|
There are some conflicting files. |
|
@gxthrj Fixed. |
gxthrj
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch