feat: Allow merging nested values in plugin config secretRef #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 37.12% 37.24% +0.11%
==========================================
Files 93 94 +1
Lines 7886 7948 +62
==========================================
+ Hits 2928 2960 +32
- Misses 4568 4595 +27
- Partials 390 393 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
kayx23
reviewed
Dec 12, 2023
| #content is "v2" | ||
| name: echo | ||
| data: | ||
| headers.X-Foo: djI= |
There was a problem hiding this comment.
- Does this have to be base64 encoded? If so, perhaps should be mentioned?
- Instead of putting a comment
#content is "v2", you could consider mentioningdjI=is base64 encoded v2 in the paragraph above?
kayx23
reviewed
Dec 12, 2023
| @@ -262,6 +262,46 @@ spec: | |||
| secretRef: echo | |||
| ``` | |||
|
|
|||
| ## Config with secretRef configuring nested fields | |||
There was a problem hiding this comment.
Could you come up with a better title? Struggle to understand what this is trying to say
There was a problem hiding this comment.
@kayx23 Please check if current title is fine. I made the change/
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
AlinsRan
reviewed
Dec 14, 2023
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
AlinsRan
approved these changes
Dec 15, 2023
monkeyDluffy6017
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
FIxes #1722
This feature allows setting specific fields on plugin configuration by passing the path to the field via secrets in a dot separated way.
What this PR does / why we need it:
Pre-submission checklist: