Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use HOSTNAME as controller name and add default value. #1946

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

tao12345666333
Copy link
Member

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

2023-08-31T02:45:31Z	info	ingress/ingress.go:145	start ingress controller
2023-08-31T02:45:31Z	error	providers/controller.go:236	failed to create leader elector: Lock identity is empty
2023-08-31T02:45:31Z	error	providers/controller.go:156	failed to setup leader election
failed to run ingress controller: Lock identity is empty
FAIL	github.com/apache/apisix-ingress-controller/cmd/ingress	0.056s

https://github.com/apache/apisix-ingress-controller/actions/runs/6032435340/job/16367603625?pr=1936#step:4:154

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1946 (65f0751) into master (0bbdc4f) will not change coverage.
The diff coverage is n/a.

❗ Current head 65f0751 differs from pull request most recent head 1a26453. Consider uploading reports for the commit 1a26453 to get more accurate results

@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files          93       93           
  Lines        7851     7851           
=======================================
  Hits         2895     2895           
  Misses       4568     4568           
  Partials      388      388           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 merged commit 1466e89 into apache:master Aug 31, 2023
83 checks passed
@tao12345666333 tao12345666333 deleted the feat-controller-name branch August 31, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants