-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add document to explain how to run on GKE #180
Conversation
--set ingressController.image.tag=dev \ | ||
--set ingressController.config.apisix.baseURL=http://apisix-admin:9180/apisix/admin \ | ||
--namespace ingress-apisix | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin_key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 48.65% 48.65%
=======================================
Files 30 30
Lines 1482 1482
=======================================
Hits 721 721
Misses 675 675
Partials 86 86 Continue to review full report at Codecov.
|
docs/deployments/gke.md
Outdated
--namespace ingress-apisix | ||
``` | ||
|
||
Change the `ingressController.image.tag` to the Apache APISIX version that you desire. You have to Wait for while until the correspdoning pods are running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to Wait
-> You have to wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch