-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add regression testing with apisix:dev #1721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
- Coverage 39.30% 39.29% -0.01%
==========================================
Files 91 91
Lines 8073 8075 +2
==========================================
Hits 3173 3173
- Misses 4494 4495 +1
- Partials 406 407 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I made some changes and added comment for clarification. Kindly have a look. |
Please sync changes from |
Please sync changes from https://github.com/apache/apisix-ingress-controller/blob/master/.github/workflows/e2e-test-ci.yml#L189-L200 , there are some necessary stability fixes. |
I installed a red hat extension which changes the syntax. That is why this PR failed in test. |
We should actually run it in GitHub Action to ensure that it meets expectations. #1721 (comment) |
I think the CI might have failed due to flaky errors. |
I will re-run CI. |
Can you please run the tests again please? It will be accepted. |
Type of change:
What this PR does / why we need it:
The PR tries to add regression testing with apisix:dev . It tries to resolve issue#1075 (#1075). Previously, apisix:dev was used for e2e testing by default, but this affected the development experience and sometimes resulted in false negatives where e2e tests failed due to changes in APISIX. By adding a scheduled job to use apisix:dev image for regression testing, your PR aims to address these concerns and improve the testing process.
Pre-submission checklist: