bugfix: fix secret created later than apisixtls #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingsamuel
requested review from
tao12345666333 and
AlinsRan
and removed request for
tao12345666333
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
lingsamuel
force-pushed
the
secret-sync-creation
branch
from
e6b8b5e
to
4e36731
Compare
|
please check failed jobs |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 41.48% 41.49%
=======================================
Files 89 89
Lines 7667 7668 +1
=======================================
+ Hits 3181 3182 +1
Misses 4122 4122
Partials 364 364
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlinsRan
approved these changes
Mar 10, 2023
tao12345666333
approved these changes
Mar 17, 2023
lingsamuel
added a commit
to lingsamuel/apisix-ingress-controller
that referenced
this pull request
Mar 31, 2023
Merged
1 task
lingsamuel
added a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Fixes #1190
Cache
ApisixTls -> Secretrelationship even if the translation failed. This can fix secret created later than ApisixTls case.