Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: monitoring apisix with helm chart #1683

Merged
merged 13 commits into from
Mar 8, 2023
Merged

Conversation

lingsamuel
Copy link
Member

  • Documentation

Require apache/apisix-helm-chart#478

docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Feb 23, 2023
lingsamuel and others added 6 commits February 23, 2023 16:33
Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com>
Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com>
Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall content is correct.

But I think it is possible to add a summary. to make the documentation look more complete.

docs/en/latest/monitoring.md Show resolved Hide resolved
docs/en/latest/monitoring.md Outdated Show resolved Hide resolved
docs/en/latest/monitoring.md Show resolved Hide resolved
@lingsamuel lingsamuel requested a review from AlinsRan March 7, 2023 09:19
@tao12345666333 tao12345666333 merged commit 13d2b5d into master Mar 8, 2023
@tao12345666333 tao12345666333 deleted the lingsamuel-patch-2 branch March 8, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants