-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic at empty http spec #1660
fix: panic at empty http spec #1660
Conversation
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@tao12345666333 PTAL, thx |
Codecov Report
@@ Coverage Diff @@
## master #1660 +/- ##
==========================================
- Coverage 41.09% 41.01% -0.09%
==========================================
Files 88 88
Lines 7550 7566 +16
==========================================
Hits 3103 3103
- Misses 4087 4103 +16
Partials 360 360
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
i think this #1654 is the same situation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Can you create an e2e test case to cover this?
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@tao12345666333 add an e2e-test case for empty http spec, but i am not sure the case is expected, PTAL, thx |
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@lingsamuel @AlinsRan first pr need one more reviewer, PTAL, thx |
Signed-off-by: Basuotian basuoluomiu@gmail.com
Type of change:
What this PR does / why we need it:
Fix: #1659
Pre-submission checklist: