Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic at empty http spec #1660

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

basuotian
Copy link
Contributor

@basuotian basuotian commented Feb 9, 2023

Signed-off-by: Basuotian basuoluomiu@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Fix: #1659

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@basuotian basuotian closed this Feb 9, 2023
@basuotian basuotian reopened this Feb 9, 2023
@basuotian
Copy link
Contributor Author

@tao12345666333 PTAL, thx

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #1660 (63987d2) into master (84d11a1) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   41.09%   41.01%   -0.09%     
==========================================
  Files          88       88              
  Lines        7550     7566      +16     
==========================================
  Hits         3103     3103              
- Misses       4087     4103      +16     
  Partials      360      360              
Impacted Files Coverage Δ
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)
pkg/providers/ingress/ingress.go 4.05% <0.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Fabriceli
Copy link
Contributor

i think this #1654 is the same situation

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Can you create an e2e test case to cover this?

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@basuotian
Copy link
Contributor Author

@tao12345666333 add an e2e-test case for empty http spec, but i am not sure the case is expected, PTAL, thx

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@basuotian basuotian requested review from tao12345666333 and removed request for lingsamuel and AlinsRan February 10, 2023 11:36
@basuotian
Copy link
Contributor Author

basuotian commented Feb 14, 2023

@lingsamuel @AlinsRan first pr need one more reviewer, PTAL, thx

@tao12345666333 tao12345666333 merged commit 4241b67 into apache:master Feb 14, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Feb 14, 2023
lingsamuel pushed a commit to lingsamuel/apisix-ingress-controller that referenced this pull request Mar 31, 2023
lingsamuel added a commit that referenced this pull request Mar 31, 2023
Co-authored-by: Basuotian <93654253+basuotian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: apply ingress yaml , controller pod got CrashLoopBackOff
5 participants