feat: sync apisix upstream labels #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,7 @@ func (t *translator) translateExternalApisixUpstream(namespace, upstream string) | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| ups.Metadata.Labels = au.ObjectMeta.Labels | |||
There was a problem hiding this comment.
I don't think this is appropriate, it will overwrite all labels.
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 41.48% 41.47% -0.02%
==========================================
Files 89 89
Lines 7667 7669 +2
==========================================
Hits 3181 3181
- Misses 4122 4123 +1
- Partials 364 365 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lingsamuel
approved these changes
Mar 6, 2023
shreemaan-abhishek
requested review from
tao12345666333
and removed request for
AlinsRan
…into sycn-upstream-labels
…into sycn-upstream-labels
AlinsRan
approved these changes
Mar 7, 2023
tao12345666333
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Fixes #775
Pre-submission checklist: