Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bad configuration item: apisix-admin-api-version #1551

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Dec 22, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Ref:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan changed the title fix: Bad configuration item: fix: Bad configuration item: apisix-admin-api-version Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #1551 (bfc5705) into master (4208ca7) will increase coverage by 0.11%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
+ Coverage   41.41%   41.53%   +0.11%     
==========================================
  Files          85       87       +2     
  Lines        7406     7416      +10     
==========================================
+ Hits         3067     3080      +13     
+ Misses       3986     3984       -2     
+ Partials      353      352       -1     
Impacted Files Coverage Δ
...kg/providers/apisix/translation/apisix_upstream.go 62.33% <69.23%> (+6.49%) ⬆️
pkg/config/config.go 63.54% <100.00%> (-0.59%) ⬇️
pkg/providers/utils/schema.go 100.00% <100.00%> (ø)
pkg/providers/utils/scheme.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/ingress/ingress.go Outdated Show resolved Hide resolved
@tao12345666333 tao12345666333 added bug Something isn't working area/controller labels Dec 26, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Dec 26, 2022
@tao12345666333 tao12345666333 merged commit 1c42993 into apache:master Dec 26, 2022
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Dec 26, 2022
Co-authored-by: Jintao Zhang <zhangjintao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants