Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1412 #1439

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: #1412 #1439

merged 1 commit into from
Nov 10, 2022

Conversation

dickens7
Copy link
Contributor

@dickens7 dickens7 commented Nov 4, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@dickens7
Copy link
Contributor Author

dickens7 commented Nov 7, 2022

Please help me re-run ci.

@tao12345666333
Copy link
Member

All checks have passed

@tao12345666333 tao12345666333 added the bug Something isn't working label Nov 7, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Nov 7, 2022
@tao12345666333 tao12345666333 linked an issue Nov 7, 2022 that may be closed by this pull request
bug: failed to reflect pluginConfig delete to cache: still in use #1412
Closed
@tao12345666333 tao12345666333 merged commit d43fd97 into apache:master Nov 10, 2022
@tao12345666333
Copy link
Member

will backport to v1.5.1

@dickens7 dickens7 deleted the fix-1412-for-master branch November 11, 2022 01:58
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Nov 20, 2022
@tao12345666333
bug: failed to reflect pluginConfig delete to cache(apache#1439)
ddd59ba 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333 added a commit that referenced this pull request Nov 21, 2022
@tao12345666333
bug: failed to reflect pluginConfig delete to cache(#1439) (#1470)
93930b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlinsRan AlinsRan AlinsRan approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel Awaiting requested review from lingsamuel

Assignees
No one assigned
Labels
bug Something isn't working process/cherry-picked
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

bug: failed to reflect pluginConfig delete to cache: still in use
3 participants
@dickens7 @tao12345666333 @AlinsRan