Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster.metricsCollector invoked before assign when MountWebhooks #1428

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

zou8944
Copy link
Contributor

@zou8944 zou8944 commented Nov 2, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@zou8944
Copy link
Contributor Author

zou8944 commented Nov 2, 2022

the issue: #1427

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #1428 (a19da39) into master (eff8ce1) will increase coverage by 0.54%.
The diff coverage is 36.90%.

❗ Current head a19da39 differs from pull request most recent head 28cad96. Consider uploading reports for the commit 28cad96 to get more accurate results

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   40.89%   41.44%   +0.54%     
==========================================
  Files          78       82       +4     
  Lines        7231     7232       +1     
==========================================
+ Hits         2957     2997      +40     
+ Misses       3933     3889      -44     
- Partials      341      346       +5     
Impacted Files Coverage Δ
pkg/api/validation/apisix_consumer.go 0.00% <ø> (ø)
pkg/api/validation/apisix_route.go 24.59% <ø> (+2.85%) ⬆️
pkg/api/validation/apisix_tls.go 0.00% <ø> (ø)
pkg/api/validation/apisix_upstream.go 0.00% <ø> (ø)
pkg/apisix/apisix.go 61.36% <ø> (ø)
pkg/apisix/resource.go 56.79% <0.00%> (-6.23%) ⬇️
pkg/config/config.go 64.13% <ø> (-2.22%) ⬇️
pkg/providers/apisix/translation/apisix_route.go 31.51% <ø> (+6.48%) ⬆️
pkg/providers/apisix/translation/translator.go 0.00% <ø> (ø)
pkg/providers/ingress/translation/annotations.go 58.82% <ø> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333
Copy link
Member

Please check the lint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

bug: cluster.metricsCollector invoked before assign a value
5 participants