-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restruct pkg/ingress #1204
Restruct pkg/ingress #1204
Conversation
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
===========================================
+ Coverage 29.55% 42.64% +13.09%
===========================================
Files 81 73 -8
Lines 10166 6462 -3704
===========================================
- Hits 3005 2756 -249
+ Misses 6834 3409 -3425
+ Partials 327 297 -30
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let's move forward
Init(ctx context.Context) error | ||
ResourceSync() | ||
|
||
GetSslFromSecretKey(string) *sync.Map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a question, why do we put it here, is it a generic method?
Type of change:
What this PR does / why we need it:
Part of #1058
Submit PR for CI, I will update the changes later
This is a huge PR, so I will describe the changes and ideas in detail.
This PR is expected to be merged in 1.16, so I delete the
apisix-route-version
option. If this option should be kept for more versions, I will restore it.This PR splits
pkg/ingress
into multiple providers, includingapisix
,ingress
andk8s
, andgateway-api
was also split in a previous PR.If the E2E_ENV is not
ci
, replace ingress-controller deployment yaml imagePullPolicy toAlways
.Pre-submission checklist: