Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress-nginx Canary ? #13

Closed
chzhuo opened this issue Mar 18, 2020 · 3 comments
Closed

Support ingress-nginx Canary ? #13

chzhuo opened this issue Mar 18, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@chzhuo
Copy link
Contributor

chzhuo commented Mar 18, 2020

https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#canary

@gxthrj gxthrj self-assigned this Apr 30, 2020
@gxthrj gxthrj added the feature label Apr 30, 2020
@gxthrj
Copy link
Contributor

gxthrj commented Apr 30, 2020

https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#canary

Yes, this is a useful annotation. At present, we support it by means of plug-ins. You can refer to the custom canary plug-in on the route or service through CRD (ApisixRoute & ApisixService).

The definition of annotation will be provided as a feature in the future, because we will rely on APISIX official canary plug-in support( @membphis ), and then we will provide both annotation and plugin ways .

@gxthrj
Copy link
Contributor

gxthrj commented Dec 7, 2020

Good news, the Apache APISIX community is discussing implementing a traffic-split plug-in, based on which canary can be implemented.

The discuss mail list is https://lists.apache.org/thread.html/rf02dc53a4af5d98d2513d89256b47466934d129af06d0bdcdb49cc8e%40%3Cdev.apisix.apache.org%3E

@gxthrj gxthrj added this to the 0.1.1 milestone Dec 7, 2020
@gxthrj
Copy link
Contributor

gxthrj commented Jan 4, 2021

As traffic-split has been merged in apache/apisix#2935, we can support Canary now.
You can bind plugin in ApisixRoute or ApisixService to implement it.

@gxthrj gxthrj closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants