-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More options for standalone configuration #717
base: master
Are you sure you want to change the base?
Conversation
type: roundrobin | ||
# -- Specifies the name of the ConfigMap that contains the rule configurations. | ||
# The configuration must be set to the key named `apisix.yaml` in the configmap. | ||
existingConfigMap: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for this subchart issue: #705
Though I have not tested if this is really needed for that use case. But I think there are many reasons that some one would like to use a configmap that is created outside of this chart. For example related to devops automation, where the configuration is defined/updated separate to the chart installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this as well. The current Helm chart adds a apisix.yaml ConfigMap when it is installed in standalone mode. This ConfigMap contains a /hi route that is impossible to modify or remove. We need the ability to specify our own rule config instead of this example config.
One workaround would maybe be to "overwrite" the example config mount using extraVolumes
and extraVolumeMounts
but I much rather prefer this solution.
This pull request will be wonderfull ! :-) |
Something that could be interesting to add, we should name the configmap dynamically with the name of the relase (like most others k8s objects I think right now) As of today we cannot have multiple releases of apisix in a single namespace because of this (conflict on the fixed |
… values and added option to set the rules configuration with an existing configmap.
d37c54b
to
142baa3
Compare
The 2.x development has changed from dev to master since I created this, so I have updated the branch to match latest master. And this pull request to merge into master. |
@Gallardot Maybe you can help to get this forward also. The chart is not usable in standalone mode without this. |
hey folks o/ I'm facing the same issue, I needed to use Can I do something to help this PR to move forward? :) @Gallardot |
Related to issue: #705
Allow to set standalone configuration with chart values or by using existing ConfigMap.