Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the default port of manager api from 8080 to 9000 #931

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Dec 1, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Related issues

close #901

@codecov-io
Copy link

Codecov Report

Merging #931 (8776fae) into master (18744a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #931   +/-   ##
=======================================
  Coverage   42.82%   42.82%           
=======================================
  Files          18       18           
  Lines        1289     1289           
=======================================
  Hits          552      552           
  Misses        645      645           
  Partials       92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18744a5...8776fae. Read the comment docs.

@nic-chen nic-chen marked this pull request as ready for review December 1, 2020 06:15
@membphis
Copy link
Member

membphis commented Dec 1, 2020

we can update the architecture diagram to help users understand these ports.

do this later in a new PR.

@membphis membphis merged commit f464bbd into apache:master Dec 1, 2020
@nic-chen nic-chen deleted the default-port branch December 2, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the manger API should not listen 8080, which is the port of data plane
5 participants