-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make field ID compatible with both string and int #902
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 42.95% 42.82% -0.14%
==========================================
Files 18 18
Lines 1271 1289 +18
==========================================
+ Hits 546 552 +6
- Misses 633 645 +12
Partials 92 92
Continue to review full report at Codecov.
|
|
for the source code, need @gxthrj @ShiningRush @tokers @spacewander help ^_^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ShiningRush @tokers @spacewander |
LGTM |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
close #896