Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README for online demo #2404

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

juxianzheng
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

resolve #2369

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
@@ -46,8 +46,9 @@ Note: Currently the Dashboard does not have complete coverage of Apache APISIX f

## Demo

[Online Playground](https://106.55.144.26/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Online Playground](https://106.55.144.26/)
[Online Playground](http://106.55.144.26/)

Seems this playground only support http

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

接得好!I changed https://106.55.144.26 / to http://106.55.144.26 / and submitted it again, did I receive a new PR?

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #2404 (ff18452) into master (2f1ebac) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
- Coverage   68.57%   68.51%   -0.06%     
==========================================
  Files         131      131              
  Lines        3421     3421              
  Branches      828      828              
==========================================
- Hits         2346     2344       -2     
- Misses       1075     1077       +2     
Flag Coverage Δ
frontend-e2e-test 68.51% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 70.49% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162c5d7...ff18452. Read the comment docs.

@Baoyuantop Baoyuantop merged commit 457393a into apache:master Apr 7, 2022
@lijing-21
Copy link

Hi @juxianzheng , thank you for your contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

@juxianzheng
Copy link
Contributor Author

Hi @juxianzheng , thank you for your contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

Okay, thanks.

hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request May 24, 2022
* upstream: (28 commits)
  docs: update some tips in develop.md (apache#2451)
  fix: create upstream error when pass host is node and nodes without port (apache#2421)
  fix: correct data  type of filed Active.checks.active.https_verify_certificate (apache#2422)
  feat: basic support Apache APISIX 2.13.0 (apache#2428)
  feat: add page reload judgment (apache#2370)
  docs: Update RPM install package link (apache#2439)
  docs: Remove hyperlinks from documents (apache#2431)
  chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423)
  fix: consumer without plugins causes page crashes (apache#2437)
  chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420)
  feat: Modify plugin preview page (apache#2359)
  chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418)
  chore: use json schema instead hard code (apache#2399)
  refactor: migrate route tests to e2enew (apache#2411)
  chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414)
  chore: update the year of copyright and fix typo (apache#2417)
  docs: update online playground url (apache#2416)
  chore: update README for online demo (apache#2404)
  refactor: migrate id compatible tests to e2enew (apache#2400)
  docs: fix invalid link (apache#2366)
  ...

# Conflicts:
#	api/internal/route.go
#	web/src/components/Footer/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize demo access experience
7 participants