Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add data loader framework #2371

Merged
merged 3 commits into from
Mar 11, 2022
Merged

feat: add data loader framework #2371

merged 3 commits into from
Mar 11, 2022

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Mar 10, 2022 •
edited
Loading

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR is the basis for the refactored data import functionality, which provides the key Import/Export interface definition and DataSets data interface so that we can implement different data import implementations, such as OpenAPI or Swagger.

This is part of the refactoring, and a refactoring of the OpenAPI codec will be submitted later.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 added enhancement New feature or request backend labels Mar 10, 2022
@bzp2010 bzp2010 self-assigned this Mar 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #2371 (fdf473e) into master (2aadeff) will increase coverage by 0.43%.
The diff coverage is 94.28%.

❗ Current head fdf473e differs from pull request most recent head 61acb82. Consider uploading reports for the commit 61acb82 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
+ Coverage   68.07%   68.50%   +0.43%     
==========================================
  Files         128      131       +3     
  Lines        3358     3420      +62     
  Branches      822      828       +6     
==========================================
+ Hits         2286     2343      +57     
- Misses       1072     1077       +5
Flag Coverage Δ
frontend-e2e-test 68.50% <94.28%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 70.49% <ø> (-3.28%) ⬇️
...b/src/pages/Proto/components/ProtoDrawer/index.tsx 88.46% <88.46%> (ø)
web/src/pages/Proto/List.tsx 96.15% <96.15%> (ø)
web/src/pages/Proto/service.ts 100.00% <100.00%> (ø)
...pages/Route/components/Step1/MatchingRulesView.tsx 75.00% <100.00%> (+0.26%) ⬆️
web/src/pages/Route/transform.ts 78.30% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aadeff...61acb82. Read the comment docs.

nic-chen
nic-chen reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of the PR, I don't quite understand the background of the PR and what the end goal is to achieve, thanks.

starsz
starsz reviewed Mar 10, 2022
View reviewed changes
api/internal/handler/data_loader/loader/loader.go

import "github.com/apisix/manager-api/internal/core/entity"

type DataSets struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add desc for the struct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starsz Updated

@bzp2010
Copy link
Contributor Author

bzp2010 commented Mar 10, 2022 •
edited
Loading

Please update the description of the PR, I don't quite understand the background of the PR and what the end goal is to achieve, thanks.

@nic-chen Updated

This PR is the basis for the refactored data import functionality, which provides the key Import/Export interface definition and DataSets data interface so that we can implement different data import implementations, such as OpenAPI or Swagger.

@bzp2010 bzp2010 requested review from nic-chen and starsz March 10, 2022 04:42
@bzp2010
Copy link
Contributor Author

bzp2010 commented Mar 11, 2022

ping @starsz

@starsz
Copy link
Contributor

starsz commented Mar 11, 2022

ping @starsz

LGTM.

@bzp2010 bzp2010 requested a review from LiteSun March 11, 2022 01:25
@juzhiyuan juzhiyuan merged commit eb51353 into apache:master Mar 11, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Mar 13, 2022
Merge branch 'origin' into coding
99ee6c3 
* origin:
  feat: release 2.11.0 (apache#2361)
  feat: add data loader framework (apache#2371)
  feat: improve Consumer module (apache#2327)
  fix: ! (reverse) operator not handled correctly (apache#2364)
  chore: modify the select upstream field to upstream (apache#2344)
  feat: support protobuf on Web (apache#2320)
  chore: Extract paging related functions into standalone hook (apache#2334)
  feat: basic support Apache APISIX 2.12.1 (apache#2315)

# Conflicts:
#	web/src/helpers.tsx
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen approved these changes

@starsz starsz starsz approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@LiteSun LiteSun Awaiting requested review from LiteSun

Assignees

@bzp2010 bzp2010

Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzp2010 @codecov-commenter @starsz @juzhiyuan @nic-chen