fix: add rejected_msg field to limit-req plugin form #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better to add some test case. |
|
Hi, @oil-oil add some pictures of your changes in the description section to make it easier to review 😄 |
OK,I'll do it. |
Codecov Report
@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
- Coverage 69.91% 68.10% -1.81%
==========================================
Files 184 127 -57
Lines 7280 3374 -3906
Branches 830 830
==========================================
- Hits 5090 2298 -2792
+ Misses 1896 1076 -820
+ Partials 294 0 -294
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Could you provide some screenshoot about your change? |
|
I added a new field to the form. before: after: |
zaunist
approved these changes
Feb 14, 2022
juzhiyuan
approved these changes
Feb 15, 2022
bzp2010
reviewed
Feb 15, 2022
bzp2010
approved these changes
Feb 15, 2022
|
If the CI test passes it's ready. |
@bzp2010 I can pass the test in the development environment, can you re-execute the CI test for me? |
Baoyuantop
approved these changes
Feb 17, 2022
LiteSun
approved these changes
Feb 17, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* origin: feat: Add more fields to limit-count plugin (apache#2322) sytle : adjust width of limit-req plugin form label (apache#2316) style: add ellipsis for route table (apache#2317) fix: add rejected_msg field to limit-req plugin form (apache#2312)
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* origin: feat: Add more fields to limit-count plugin (apache#2322) sytle : adjust width of limit-req plugin form label (apache#2316) style: add ellipsis for route table (apache#2317) fix: add rejected_msg field to limit-req plugin form (apache#2312)
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* origin: feat: Add more fields to limit-count plugin (apache#2322) sytle : adjust width of limit-req plugin form label (apache#2316) style: add ellipsis for route table (apache#2317) fix: add rejected_msg field to limit-req plugin form (apache#2312)
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Mar 13, 2022
* origin: feat: Add more fields to limit-count plugin (apache#2322) sytle : adjust width of limit-req plugin form label (apache#2316) style: add ellipsis for route table (apache#2317) fix: add rejected_msg field to limit-req plugin form (apache#2312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Add rejected_msg field to limit-req plugin form.
Related issues
#2310
Checklist: