feat(route): show route id in list and edit views.

[mangoGoForward]

Signed-off-by: mango xu.weiKyrie@foxmail.com

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

• Bugfix
• New feature provided
• Improve performance
• Backport patches

What changes will this PR take into?

Display route id at route list and edit views.

Related issues

fix/resolve #1595

Checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[mangoGoForward]

Please have a look. @juzhiyuan

[juzhiyuan]

Hi @mangoGoForward, those changes LGTM, could you please add some test cases for this PR?

[juzhiyuan]

also cc @guoqqqi to have a review.

[iamayushdas]

just add the test cases as @juzhiyuan said, thanks @mangoGoForward

[zaunist]

Hi，@mangoGoForward. Can you take some screenshoot for this feature?

[mangoGoForward]

just add the test cases as @juzhiyuan said, thanks @mangoGoForward

Ok.

[mangoGoForward]

Hi @mangoGoForward, those changes LGTM, could you please add some test cases for this PR?

Thanks for your suggestion.

[guoqqqi]

LGTM, Hi @mangoGoForward, as we don't have a preview environment at the moment, it would be nice if we could post a picture up ~
If you have any questions about the test and need help. just @ me～

[mangoGoForward]

The screenshot like below:
List page

Edit page

[zaunist]

/LGTM

[mangoGoForward]

LGTM, Hi @mangoGoForward, as we don't have a preview environment at the moment, it would be nice if we could post a picture up ~ If you have any questions about the test and need help. just @ me～

Sorry, I am confused about frontend e2e test of workflow errors, and how to support test cases for this PR. Could you help me to solved if you have free time?

[juzhiyuan]

After checking the codes and screenshots, these tiny changes look good to me, too. (Just adding ID & disabled attribute), I think we can move forward with this PR to merge 🤔

[guoqqqi]

We can update this test for creating a route that

1. assert that there is an id field
2. the id is not clickable when editing

I think we can do this in another PR~

[juzhiyuan]

Hi @guoqqqi, please have a check at the CI https://github.com/apache/apisix-dashboard/runs/4655853255?check_suite_focus=true

[guoqqqi]

please have a check at the CI

just an unstable test

I will fix it in other PRs

[zaunist]

cc @okaybase @LiteSun

[codecov-commenter]

Codecov Report

Merging #2269 (7f4d292) into master (25ac15a) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2269      +/-   ##
==========================================
+ Coverage   68.07%   68.16%   +0.09%     
==========================================
  Files         127      127              
  Lines        3370     3374       +4     
  Branches      829      830       +1     
==========================================
+ Hits         2294     2300       +6     
+ Misses       1076     1074       -2     

Flag	Coverage Δ
frontend-e2e-test	68.16% <100.00%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
web/src/pages/Route/List.tsx	82.84% <ø> (ø)
web/src/pages/Route/transform.ts	77.77% <ø> (ø)
web/src/pages/Route/components/Step1/MetaView.tsx	100.00% <100.00%> (ø)
web/src/helpers.tsx	73.77% <0.00%> (+3.27%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ac15a...7f4d292. Read the comment docs.