Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authentication middleware is implemented by changing from framework droplet to framework gin #2254

Merged
merged 11 commits into from
Dec 19, 2021

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
authentication middleware is implemented by changing from framework droplet to framework gin

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #2254 (76224b3) into master (ffa596d) will increase coverage by 1.73%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
+ Coverage   68.12%   69.85%   +1.73%     
==========================================
  Files         127      184      +57     
  Lines        3369     7272    +3903     
  Branches      829      829              
==========================================
+ Hits         2295     5080    +2785     
- Misses       1074     1897     +823     
- Partials        0      295     +295     
Flag Coverage Δ
backend-e2e-test 37.12% <57.89%> (?)
backend-e2e-test-ginkgo 59.69% <57.89%> (?)
backend-unit-test 49.19% <77.77%> (?)
frontend-e2e-test 68.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/server/server.go 61.70% <ø> (ø)
api/internal/filter/authentication.go 77.77% <77.77%> (ø)
api/internal/core/server/http.go 56.52% <100.00%> (ø)
api/internal/route.go 87.50% <100.00%> (ø)
api/internal/core/storage/storage_mock.go 0.00% <0.00%> (ø)
api/internal/handler/migrate/migrate.go 59.67% <0.00%> (ø)
api/internal/filter/logging.go 92.30% <0.00%> (ø)
api/internal/handler/schema/schema.go 100.00% <0.00%> (ø)
api/internal/handler/route/route.go 80.23% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa596d...76224b3. Read the comment docs.

@starsz
Copy link
Contributor

starsz commented Dec 18, 2021

Need to fix CI @nic-chen

Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change made for security reasons?

@juzhiyuan juzhiyuan merged commit b565f7c into apache:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants