Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust buildx to fix Docker build failed #2120

Merged
merged 4 commits into from
Sep 8, 2021
Merged

fix: adjust buildx to fix Docker build failed #2120

merged 4 commits into from
Sep 8, 2021

Conversation

qsliu2017
Copy link
Contributor

@qsliu2017 qsliu2017 commented Sep 3, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR aims to fix buildx bug that causes docker build ci to fail. The change is login just before deploying step since Azure login action may change buildx driver.

I don't have an Azure account so I'm not sure it works well. But I've tested Docker Hub and it's ok.

Related issues

fix #2108

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 94eeef0

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538

😎 Browse the preview: https://deploy-preview-2120--apisix-dashboard.netlify.app/

@juzhiyuan juzhiyuan changed the title ci: fix buildx fix: adjust buildx to fix Docker build failed Sep 4, 2021
@liuxiran liuxiran requested a review from imjoey September 5, 2021 01:30
@imjoey
Copy link
Member

imjoey commented Sep 6, 2021

@qsliu2017 I found a similar issue on this: Azure/docker-login#12. As suggested in Azure/docker-login#12 (comment), how about keep using Azure/docker-login@v1, but put it right before the Deploy step?

@qsliu2017
Copy link
Contributor Author

@qsliu2017 I found a similar issue on this: Azure/docker-login#12. As suggested in Azure/docker-login#12 (comment), how about keep using Azure/docker-login@v1, but put it right before the Deploy step?

Thanks for your help, I've updated it.

@codecov-commenter
Copy link

Codecov Report

Merging #2120 (94eeef0) into master (00d80bb) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
+ Coverage   67.25%   67.42%   +0.16%     
==========================================
  Files         124      126       +2     
  Lines        3277     3294      +17     
  Branches      797      802       +5     
==========================================
+ Hits         2204     2221      +17     
  Misses       1073     1073              
Flag Coverage Δ
frontend-e2e-test 67.42% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/limit-conn.tsx 100.00% <0.00%> (ø)
web/src/components/Upstream/components/Nodes.tsx 100.00% <0.00%> (ø)
...c/components/Upstream/components/KeepalivePool.tsx 100.00% <0.00%> (ø)
...rc/components/Upstream/components/RetryTimeout.tsx 100.00% <0.00%> (ø)
web/src/components/Upstream/UpstreamForm.tsx 92.40% <0.00%> (+0.19%) ⬆️
web/src/components/Upstream/service.ts 87.93% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d80bb...94eeef0. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@imjoey imjoey merged commit 79012fd into apache:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: master ci failed with buildx failed error
5 participants