-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust buildx to fix Docker build failed #2120
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 94eeef0 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538 😎 Browse the preview: https://deploy-preview-2120--apisix-dashboard.netlify.app/ |
@qsliu2017 I found a similar issue on this: Azure/docker-login#12. As suggested in Azure/docker-login#12 (comment), how about keep using |
Thanks for your help, I've updated it. |
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
+ Coverage 67.25% 67.42% +0.16%
==========================================
Files 124 126 +2
Lines 3277 3294 +17
Branches 797 802 +5
==========================================
+ Hits 2204 2221 +17
Misses 1073 1073
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This PR aims to fix buildx bug that causes docker build ci to fail. The change is login just before deploying step since Azure login action may change buildx driver.
I don't have an Azure account so I'm not sure it works well. But I've tested Docker Hub and it's ok.
Related issues
fix #2108
Checklist: