Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): allowing limit-count to dynamically adapt to the BE rules #1998

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

wmdmomo
Copy link
Contributor

@wmdmomo wmdmomo commented Jul 25, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
The PR will change the plugin under plugin/UI (limit-count), allowing limit-count to dynamically adapt to the back-end json rules.

Related issues

fix/resolve #1588

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 25, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: d811800

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611109e14aeefe0008768f06

😎 Browse the preview: https://deploy-preview-1998--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #1998 (fe5e77a) into master (0b5196f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   64.01%   64.06%   +0.05%     
==========================================
  Files         122      122              
  Lines        3154     3164      +10     
  Branches      753      755       +2     
==========================================
+ Hits         2019     2027       +8     
- Misses       1135     1137       +2     
Flag Coverage Δ
frontend-e2e-test 64.06% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 65.82% <100.00%> (+0.21%) ⬆️
web/src/components/Plugin/UI/limit-count.tsx 87.17% <100.00%> (+3.84%) ⬆️
web/src/components/Plugin/UI/plugin.tsx 82.60% <100.00%> (ø)
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5196f...fe5e77a. Read the comment docs.

@LiteSun LiteSun changed the title feat(plugin): fix UI limit-count feat(plugin): allowing limit-count to dynamically adapt to the BE rules Jul 26, 2021
@juzhiyuan juzhiyuan requested a review from liuxiran July 29, 2021 13:40
@LiteSun LiteSun requested a review from bzp2010 August 20, 2021 03:18
@liuxiran liuxiran merged commit 4c2471b into apache:master Aug 20, 2021
@liuxiran
Copy link
Contributor

merged, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize front-end validation of fields
6 participants