-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect import paths #1899
Conversation
Deploy preview for apisix-dashboard ready! Built with commit 2bd58fe |
Waiting for GitHub Action to be fixed. https://www.githubstatus.com/ |
It would be great to have a checker here:
|
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 68.85% 68.91% +0.06%
==========================================
Files 122 122
Lines 3111 3111
Branches 745 745
==========================================
+ Hits 2142 2144 +2
+ Misses 969 967 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it. |
Got it. Approved 😀 |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This PR aims to fix the broken Route creator, this issue is caused by the invalid import path, and when run building, we don't have a checker to check this.
To prevent this occasional case, we may have
Husky
enabled and check paths.Related issues
fix #1889
Checklist: