Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect import paths #1899

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented May 16, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR aims to fix the broken Route creator, this issue is caused by the invalid import path, and when run building, we don't have a checker to check this.

To prevent this occasional case, we may have Husky enabled and check paths.

Related issues

fix #1889

Checklist:

  • Did you explain what problem does this PR solves? Or what new features have been added?
  • Have you added corresponding test cases? No need for this issue
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 16, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 2bd58fe

https://deploy-preview-1899--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member Author

Waiting for GitHub Action to be fixed. https://www.githubstatus.com/

@juzhiyuan juzhiyuan changed the title fix: invalid import issues fix: incorrect import paths May 16, 2021
@juzhiyuan juzhiyuan requested a review from imjoey May 16, 2021 14:52
@juzhiyuan
Copy link
Member Author

It would be great to have a checker here:

  1. We could enable Husky to check pre-commit;
  2. When changed files contain local cache paths, like @/.umi/xx, just throw errors.

@codecov-commenter
Copy link

Codecov Report

Merging #1899 (2bd58fe) into master (e14cb8c) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
+ Coverage   68.85%   68.91%   +0.06%     
==========================================
  Files         122      122              
  Lines        3111     3111              
  Branches      745      745              
==========================================
+ Hits         2142     2144       +2     
+ Misses        969      967       -2     
Flag Coverage Δ
frontend-e2e-test 68.91% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/cors.tsx 86.95% <ø> (ø)
web/src/components/PluginFlow/constants.ts 29.03% <ø> (ø)
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14cb8c...2bd58fe. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from Yiyiyimu May 17, 2021 01:01
@juzhiyuan
Copy link
Member Author

Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it.

@Yiyiyimu
Copy link
Member

Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it.

Got it. Approved 😀

@LiteSun LiteSun merged commit 4174435 into apache:master May 17, 2021
@juzhiyuan juzhiyuan deleted the fix-invalid-import branch May 17, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create/Configure Route page is broken
5 participants