Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add referer-restriction plugin form #1727

Merged
merged 16 commits into from
Apr 15, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Apr 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.
image

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@membphis
Copy link
Member

membphis commented Apr 9, 2021

Can you provide a screenshot of the effect?

@LiteSun
Copy link
Member Author

LiteSun commented Apr 9, 2021

Can you provide a screenshot of the effect?

sure.

web/cypress/support/commands.js Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/referer-restriction.tsx Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1727 (0cbfd22) into master (fb75809) will decrease coverage by 0.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   72.87%   72.86%   -0.02%     
==========================================
  Files         117      118       +1     
  Lines        2776     2793      +17     
  Branches      670      673       +3     
==========================================
+ Hits         2023     2035      +12     
- Misses        753      758       +5     
Flag Coverage Δ
frontend-e2e-test 72.86% <72.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/src/components/Plugin/UI/referer-restriction.tsx 66.66% <66.66%> (ø)
web/src/components/Plugin/UI/plugin.tsx 80.95% <100.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb75809...0cbfd22. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 0cbfd22

https://deploy-preview-1727--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member

juzhiyuan commented Apr 12, 2021

image

@LiteSun failed when building

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rechecked with https://github.com/apache/apisix/blob/master/apisix/plugins/referer-restriction.lua, please update i18n in the new PR.

web/cypress/support/commands.js Outdated Show resolved Hide resolved
@LiteSun LiteSun merged commit a97c813 into apache:master Apr 15, 2021
@LiteSun LiteSun deleted the referer-restriction-plugin-form branch April 15, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants