chore: refactor upstream form module

[juzhiyuan]

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

• Bugfix
• New feature provided
• Improve performance
• Backport patches

What changes will this PR take into?

• make components smaller & clearer
• added default values (will be resolved in a new PR)

Checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases? (TODO)
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[juzhiyuan]

Hi, I noticed that there have too many changes!

This is due to I separate the UpstreamForm file (more than 813 lines) into some sub-components, to make this module more clear for developers.

According to the schema_def file: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L114 , I structured the components according to fields style. e.g active.host -> <ActiveCheck.Host />.

[juzhiyuan]

This PR doesn't change logics, only adjust the structure so we could know more clear about this component. Test is under debugging.

[codecov-io]

Codecov Report

Merging #1726 (55d0c0e) into master (8b6080d) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
- Coverage   71.86%   71.61%   -0.26%     
==========================================
  Files          47       47              
  Lines        3128     3128              
==========================================
- Hits         2248     2240       -8     
- Misses        638      645       +7     
- Partials      242      243       +1     

Flag	Coverage Δ
backend-e2e-test	62.37% <ø> (-0.36%)	⬇️
backend-e2e-test-ginkgo	49.36% <ø> (+0.25%)	⬆️
backend-unit-test	52.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/internal/core/store/storehub.go	71.02% <0.00%> (-3.74%)	⬇️
api/internal/core/storage/etcd.go	47.27% <0.00%> (-3.64%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6080d...55d0c0e. Read the comment docs.

[membphis]

this is a big PR, need @LiteSun @liuxiran to confirm first

[juzhiyuan]

yes, also needs @imjoey @bzp2010 's opinion.

[imjoey]

@juzhiyuan the adjustment is OK on my side which makes the code structure much more intuitive and easier for maintenance.

[juzhiyuan]

yes! And if we want to use the field like active.host, we just need to create a TSX file ./components/active-check/Host.tsx, and use it <ActiveCheck.Host />. That's easier to use & read!

BTW, backend CI failed due to luarocks.org is unstable today 🤔 @imjoey

[juzhiyuan]

I'm honored to have this Component got structure updated :)

[LiteSun]

should keep same style "" or ' '.

[juzhiyuan]

yes, will be formatted globally in a new PR.

[juzhiyuan]

#1746

[imjoey]

/lgtm

Thanks, @juzhiyuan.

[juzhiyuan]

Hi @liuxiran, this PR needs your review :) You could review this one first, after issues you find (maybe) are resolved, I will add features for Upstream.