Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: searching upstream by users input while creating new routes #1589

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

bisakhmondal
Copy link
Member

Please answer these questions before submitting a pull request

New feature or improvement

apisix.mp4

Thank You.

@codecov-io
Copy link

codecov-io commented Mar 13, 2021

Codecov Report

Merging #1589 (eaab683) into master (2d6339e) will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
- Coverage   71.57%   70.18%   -1.39%     
==========================================
  Files         132       46      -86     
  Lines        5341     3019    -2322     
  Branches      584        0     -584     
==========================================
- Hits         3823     2119    -1704     
+ Misses       1273      655     -618     
  Partials      245      245              
Flag Coverage Δ
backend-e2e-test 60.74% <ø> (-0.14%) ⬇️
backend-e2e-test-ginkgo 46.27% <ø> (ø)
backend-unit-test 51.54% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 43.63% <0.00%> (-3.64%) ⬇️
web/src/pages/SSL/service.ts
.../src/pages/User/components/LoginMethodPassword.tsx
...b/src/pages/User/components/LoginMethodExample.tsx
...eb/src/components/PluginOrchestration/constants.ts
...ages/Route/components/Step2/RequestRewriteView.tsx
web/src/pages/Consumer/components/Preview.tsx
web/src/components/Plugin/PluginPage.tsx
web/src/pages/Route/components/Step1/index.tsx
.../components/PluginOrchestration/DrawPluginStyle.ts
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6339e...eaab683. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the code , it would be better to add test case for this nice new feature

@bisakhmondal
Copy link
Member Author

LGTM for the code , it would be better to add test case for this nice new feature

Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think?

@juzhiyuan
Copy link
Member

LGTM for the code , it would be better to add test case for this nice new feature

Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think?

Agree :) Not urgent IMO.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think?

A single step makes a thousand miles ^_^
Adding test cases later is also a good option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discuss: select upstream in the "Define API Backend Server" should provide a search function
6 participants