-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: searching upstream by users input while creating new routes #1589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
- Coverage 71.57% 70.18% -1.39%
==========================================
Files 132 46 -86
Lines 5341 3019 -2322
Branches 584 0 -584
==========================================
- Hits 3823 2119 -1704
+ Misses 1273 655 -618
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the code , it would be better to add test case for this nice new feature
Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think? |
Agree :) Not urgent IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think?
A single step makes a thousand miles ^_^
Adding test cases later is also a good option
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
resolves discuss: select upstream in the "Define API Backend Server" should provide a search function #1555
New feature or improvement
apisix.mp4
Thank You.