feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo #1570
Conversation
…t-with-ginkgo) with ginkgo
|
cli test failed.. @Jaycean |
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
- Coverage 71.54% 70.18% -1.36%
==========================================
Files 132 46 -86
Lines 5341 3019 -2322
Branches 584 0 -584
==========================================
- Hits 3821 2119 -1702
+ Misses 1275 655 -620
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Jaycean
force-pushed
the
rewrite-e2e-test-route-with-scripte-luacoe-test-with-ginkgo
branch
from
be6ac94
to
55fd1a4
Compare
The error is due to the element being fetched before the data has finished loading, creating a separation from the element after the data has finished loading. |
|
wait for CI |
| }), | ||
| ) | ||
| ginkgo.It("verify the log generated by script set in Step-4 above", func() { | ||
| t := ginkgo.GinkgoT() |
There was a problem hiding this comment.
We can reuse the ginkgo.GinkgoT().
So we can put it in front.
There was a problem hiding this comment.
@Jaycean could we put ginkgo.GinkgoT() in front, all test cases use a t ?
There was a problem hiding this comment.
@nic-chen
Not all test cases use t, which is usually used table.entry we don't need to use t.
But at present, t is used in many places.
There was a problem hiding this comment.
I mean you can put it in front.
So line 142 and line 327 can merge into one.
web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js
Outdated
Show resolved
Hide resolved
…-test-with-ginkgo
Jaycean
force-pushed
the
rewrite-e2e-test-route-with-scripte-luacoe-test-with-ginkgo
branch
from
f2221d5
to
6d54f94
Compare
|
Thanks! @Jaycean |
Jaycean
deleted the
rewrite-e2e-test-route-with-scripte-luacoe-test-with-ginkgo
branch
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement