feat: supports changing number of executing cpu cores for manager api #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsz
reviewed
Mar 9, 2021
nic-chen
reviewed
Mar 10, 2021
nic-chen
reviewed
Mar 10, 2021
Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 69.15% 73.21% +4.05%
==========================================
Files 49 86 +37
Lines 3164 2322 -842
Branches 0 584 +584
==========================================
- Hits 2188 1700 -488
+ Misses 728 622 -106
+ Partials 248 0 -248
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
starsz
approved these changes
Mar 10, 2021
|
@bisakhmondal merged, thanks a lot. |
|
You're welcome. Thanks for the review guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
resolves feature: support custom CPU quantity used for
manager api#682New feature or improvement
Supports changing the number of os threads attached to the goroutines.
For performance reason, if in the configuration file, the defined
max_cpuis greater than the number of available cpu cores (including hyperthreading), themanager apiwill stick to the max available cores. As it has a certain limit to boost the performance since the context switching of goroutines from the same os thread is a lot faster than goroutines from different threads.