Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test #1559

Merged
merged 3 commits into from
Mar 8, 2021
Merged

test: update test #1559

merged 3 commits into from
Mar 8, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Mar 5, 2021

Please answer these questions before submitting a pull request


Bugfix

  • Description
    e2e failed
  • How to fix?
    Enhanced stability, modified the domSelector name for some tests.

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1559 (9b80eda) into master (938b2b9) will increase coverage by 2.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
+ Coverage   70.86%   73.33%   +2.46%     
==========================================
  Files         135       86      -49     
  Lines        5485     2321    -3164     
  Branches      583      583              
==========================================
- Hits         3887     1702    -2185     
+ Misses       1350      619     -731     
+ Partials      248        0     -248     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 73.33% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/handler.go
api/internal/filter/ip_filter.go
api/internal/utils/version.go
api/internal/filter/request_id.go
api/internal/core/store/query.go
api/internal/core/store/validate.go
api/internal/handler/tool/tool.go
api/internal/handler/service/service.go
api/internal/handler/global_rule/global_rule.go
api/internal/filter/logging.go
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938b2b9...9b80eda. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from LiteSun March 6, 2021 00:24
@LiteSun LiteSun requested a review from juzhiyuan March 8, 2021 13:57
@juzhiyuan juzhiyuan merged commit 6dce9e0 into apache:master Mar 8, 2021
liuxiran pushed a commit to liuxiran/apisix-dashboard that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants