Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frontend e2e report on pr comment #1529

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Mar 1, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

Please add the corresponding test cases if necessary.


Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #1529 (ccd477e) into master (816ba9e) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
+ Coverage   68.61%   69.44%   +0.82%     
==========================================
  Files          48      128      +80     
  Lines        3056     5188    +2132     
  Branches        0      534     +534     
==========================================
+ Hits         2097     3603    +1506     
- Misses        718     1345     +627     
+ Partials      241      240       -1     
Flag Coverage Δ
backend-e2e-test 55.59% <ø> (?)
backend-e2e-test-ginkgo 33.83% <ø> (?)
backend-unit-test 51.69% <ø> (?)
frontend-e2e-test 70.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/libs/iconfont.js 41.37% <0.00%> (ø)
web/src/components/Upstream/constant.ts 100.00% <0.00%> (ø)
web/src/pages/SSL/components/Step1/index.tsx 40.74% <0.00%> (ø)
web/src/components/RawDataEditor/RawDataEditor.tsx 52.94% <0.00%> (ø)
...components/PluginOrchestration/components/Page.tsx 100.00% <0.00%> (ø)
...pages/SSL/components/CertificateUploader/index.tsx 4.16% <0.00%> (ø)
web/src/pages/Setting/service.ts 100.00% <0.00%> (ø)
web/src/pages/Route/Create.tsx 83.48% <0.00%> (ø)
web/src/pages/Consumer/Create.tsx 76.08% <0.00%> (ø)
web/src/pages/Consumer/components/Step1.tsx 100.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816ba9e...ccd477e. Read the comment docs.

Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add backend-e2e-test

@LiteSun LiteSun merged commit 2dbd204 into apache:master Mar 2, 2021
@LiteSun LiteSun deleted the feat-fe-pr-comment branch March 2, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants