Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the CI error for #1518 #1523

Merged
merged 5 commits into from
Mar 1, 2021
Merged

fix: the CI error for #1518 #1523

merged 5 commits into from
Mar 1, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Feb 27, 2021

Please answer these questions before submitting a pull request


Bugfix

  • Description
    Create and Delete Plugin List Unstable
  • How to fix?
    Move to get plugin-dataset from beforeEach to the first test, as it is not required for each individual test.

@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #1523 (b66fcfc) into master (4dd7b15) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   68.97%   68.88%   -0.10%     
==========================================
  Files          48       48              
  Lines        3056     3056              
==========================================
- Hits         2108     2105       -3     
- Misses        708      711       +3     
  Partials      240      240              
Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 49.09% <0.00%> (-1.82%) ⬇️
api/internal/core/store/store.go 86.74% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd7b15...b66fcfc. Read the comment docs.

@LiteSun LiteSun merged commit 816ba9e into apache:master Mar 1, 2021
@juzhiyuan juzhiyuan deleted the fix-1518 branch March 1, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants