feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 69.01% 68.97% -0.04%
==========================================
Files 48 48
Lines 3056 3056
==========================================
- Hits 2109 2108 -1
- Misses 707 708 +1
Partials 240 240
Continue to review full report at Codecov.
|
nic-chen
approved these changes
Feb 28, 2021
starsz
reviewed
Mar 1, 2021
| assert.Nil(t, err) | ||
| resp, err := http.DefaultClient.Do(req) | ||
| assert.Nil(t, err) | ||
| respBody, err := ioutil.ReadAll(resp.Body) |
starsz
reviewed
Mar 1, 2021
| req, err := http.NewRequest("GET", url, nil) | ||
| assert.Nil(t, err) | ||
| resp, err := http.DefaultClient.Do(req) | ||
| assert.Nil(t, err) |
There was a problem hiding this comment.
Defer closing the resp.Body at here.
There was a problem hiding this comment.
done. It's my negligence. I'll check the previous use cases and correct the same problems
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_chash_query_string
branch
from
0f787ea
to
1d18070
Compare
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_chash_query_string
branch
from
1d18070
to
a1709a8
Compare
|
cc @starsz PTAL, Thks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement