Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(be): search by status on the route list page is invalid (backport to v2.3) #1224

Merged

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jan 7, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

As the preparation for release v2.3, this PR is going to cherry-pick 3f8060e from master branch to v2.3 branch . Regarding to the details, please refer to #1207 .

Noted that the FE counterpart of the bugfix (#1189) has already been merged into v2.3, no need for cherry-pick.

)

* fix search by status on the route list page is invalid

* Fix test cases and references

* Update route.go

* Update route.go

* Format error repair

* use strconv.Itoa Method conversion uint8

* chore: use the correct API version (apache#1215)

Co-authored-by: litesun <sunyi@apache.org>

fix: online debug body params support content-type x-www-form-urlencoded (apache#1201)

* fix: online debug body params support content-type x-www-form-urlencoded

* fix: body code mirror support different mode

* fix: use enum instead of real string

* fix: lint error

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

feat: add tips when plugin type is auth and schemaType is not consumer (apache#1219)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

* Fix indent format problem

Co-authored-by: 琚致远 <juzhiyuan@apache.org>
@imjoey imjoey changed the base branch from master to v2.3 January 7, 2021 01:18
@codecov-io
Copy link

Codecov Report

Merging #1224 (0eddbf8) into v2.3 (d194c15) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v2.3    #1224      +/-   ##
==========================================
+ Coverage   42.38%   42.44%   +0.05%     
==========================================
  Files          31       31              
  Lines        1930     1932       +2     
==========================================
+ Hits          818      820       +2     
  Misses       1001     1001              
  Partials      111      111              
Impacted Files Coverage Δ
api/internal/handler/route/route.go 43.43% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d194c15...0eddbf8. Read the comment docs.

@juzhiyuan
Copy link
Member

@imjoey Hi, I just added those 2 labels, could you have the privilege to select label?

@juzhiyuan juzhiyuan merged commit d39951b into apache:v2.3 Jan 7, 2021
@imjoey imjoey deleted the v2.3_backport_status_search_route_list branch January 7, 2021 01:39
@imjoey
Copy link
Member Author

imjoey commented Jan 7, 2021

@imjoey Hi, I just added those 2 labels, could you have the privilege to select label?

@juzhiyuan unfortunately, it seems not. 😄

@juzhiyuan
Copy link
Member

got it, if the future PR needs label, kindly let us know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants