-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import route from OpenAPI Specification3.0 #1102
feat: import route from OpenAPI Specification3.0 #1102
Conversation
Signed-off-by: Jacean <jinchen_jacean@163.com>
Any update about this feature? |
# Conflicts: # api/go.mod # api/go.sum # api/internal/core/entity/entity.go
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
===========================================
- Coverage 65.42% 43.77% -21.65%
===========================================
Files 43 35 -8
Lines 2655 2508 -147
===========================================
- Hits 1737 1098 -639
- Misses 713 1253 +540
+ Partials 205 157 -48
Continue to review full report at Codecov.
|
After communicated with @nic-chen , he will continue doing import on current pr, and @Jaycean will go on doing export route on another pr, and it is planed to be ready later next week. cc @juzhiyuan |
…/apisix-dashboard into import_export_route_from_openapi
Do we need to add a test case about a route with as many props as possible? |
sure |
# Conflicts: # api/internal/conf/conf.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pr covered all the requirements refer to #825
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very grateful to you.
Thanks for @nic-chen and all reviewers, pr megerd |
Signed-off-by: Jacean jinchen_jacean@163.com
Import & Export route from OpenAPI Specification3.0
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
issue: [Proposal]: Import & Export route from OpenAPI Specification3.0 #825
New feature or improvement
speed of progress:
It has implemented the basic information and authentication plugins of OpenAPI configuration file: basic-auth, JWT-auth, key-auth; parameter authentication plugin, request-validation and request header parameter parsing.
Remaining problems:
When writing etcd for parameter verification, the system will report the following error because there are no upstream and service related parameters in OpenAPI.
It is difficult to write to etcd in batch because it is necessary to verify the properties of upstream and service when writing data to etcd, and there is no relevant interface in the underlying layer.